Skip to content

Remove dark-only Palette aliases and Tone.color; one home for the deck slot rule - #158

Merged
Skeyelab merged 1 commit into
mainfrom
tidy-155
Nov 16, 2026
Merged

Skeyelab merged 1 commit into
mainfrom
tidy-155

Conversation

@Skeyelab

Copy link
Copy Markdown
Member

Cleanup from the #137 and #130 reviews. No behavior change.

Closes #155

  • Palette: removed the dark-theme aliases (Palette.background, .panel and the others). Nothing in App or the Kit used them.
  • Tone.color: removed the dark-only StatusLight.Tone.color. The app uses color(in:). The tone test already checked color(in: Palette.dark) with the same literals, so I only dropped its duplicate line.
  • Deck slot rule: "slot is odd and in 1-7, deck = (slot + 1) / 2" now lives in DeckColors.deck(forSlot:). Both DeckColors.updated(byPalette:) and Coordinator.noteBlackSlot call it.

Checks

  • The existing tests are the guard: 359 pass.
  • The local Release build succeeded.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VCgWWsdAAQXJWYmYEXyTy7

…for the deck slot rule

The app reads theme colors through ThemePalette and Tone.color(in:), so the
aliases and Tone.color had only a test left. The rule that a deck's palette
slot is odd and in 1-7 now lives in DeckColors.deck(forSlot:). No behavior
change.

Closes #155

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VCgWWsdAAQXJWYmYEXyTy7
@Skeyelab Skeyelab added this to the v1.0: native Mac app milestone Nov 16, 2026
@Skeyelab
Skeyelab enabled auto-merge November 16, 2026 05:05
@Skeyelab
Skeyelab merged commit 2afd130 into main Nov 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup: drop unused dark-only Palette aliases and Tone.color; one rule for deck palette slots

1 participant